Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

All Mist/Wallet data should be stored per-network #797

Open
hiddentao opened this issue Jun 9, 2016 · 3 comments
Open

All Mist/Wallet data should be stored per-network #797

hiddentao opened this issue Jun 9, 2016 · 3 comments

Comments

@hiddentao
Copy link
Contributor

All account, contract and other should be associated with a network when being stored within Mist's internal data stores (whether Meteor or backend). This way when the network is switched it is able to cleanly load in the appropriate data for the new network.

@luclu
Copy link
Contributor

luclu commented Jun 12, 2016

This could also improve the situation on these ones:

  • Backup menuentries always redirect to default main-net geth-data-directories
  • Mining menuentry only works on test-net (no private-net) and if mist is in control of geth session

@luclu luclu modified the milestones: 0.8, 0.8.2 Jul 11, 2016
@luclu
Copy link
Contributor

luclu commented Jul 21, 2016

Network-Id query:

$(which geth) version | grep -m1 "Network Id" | awk '{print $3}'

or via regex:

(?<=Network Id: )\d+

@hiddentao
Copy link
Contributor Author

At the moment we use the genesis block id to figure out which network the user is on, see https://github.com/ethereum/mist/blob/develop/interface/client/templates/elements/networkIndicator.js#L21.

I propose keeping to this mechanism as it's more reliable than network id (a Geth user could startup Geth and set networkid to whatever they want, e.g. especially if they're simply running a local private network).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants