[UX] Adds shortcuts to select tabs: Cmd + [1-9]

[evertonfraga]

Simple like that. The absence of those shortcuts was sort of bugging me.

[mention-bot]

@evertonfraga, thanks for your PR! By analyzing the history of the files in this pull request, we identified @frozeman, @luclu and @hiddentao to be potential reviewers.

[frozeman]

I think this code is better part of the sideBar.js Can you please move it over?

[evertonfraga]

@frozeman yes, great suggestion. I've moved to sidebar and extracted the two methods to Helpers.

[alexvandesande]

It's not working for me. Actually, it's not even invoking the 'document keydown' event, I tested and it won't even do a console.log

Also, why is command+9 a shortcut to the last tab? And while you're at it, make ctrl+tab (on mac) the "go to next tab" button as it is currently on both safari and chrome

[frozeman]

So on mac super+number is the tab number, and ctrl + tab is next tab.

@evertonfraga can you please check why its not working for alex and also add the next tab ctrl + tab ?

[evertonfraga]

Sure, checking out.

[evertonfraga]

Oh, I get why it isn't working now. As I was refactoring, using auto-reload, it kept all the key bindings from previous delegations, when they were on mistUI. It's not working indeed @alexvandesande.

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.