Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Light client #1530

Closed
wants to merge 19 commits into from
Closed

Light client #1530

wants to merge 19 commits into from

Conversation

alexvandesande
Copy link
Collaborator

@alexvandesande alexvandesande commented Dec 19, 2016

Puts light client option on the developer menu, not default, and remembers the user option

@mention-bot
Copy link

@alexvandesande, thanks! @luclu, @frozeman and @evertonfraga, please review this.

@@ -353,12 +353,12 @@ class EthereumNode extends EventEmitter {
if (network == 'test') {
args = (nodeType === 'geth')
? ['--testnet', '--fast', '--ipcpath', Settings.rpcIpcPath]
: ['--morden', '--unsafe-transactions'];
: ['--ropstein', '--unsafe-transactions'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you invested that flag?
Party uses: parity --chain ropsten.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is cpp using ropstein, instead of ropsten?

@luclu
Copy link
Contributor

luclu commented Dec 19, 2016

My initial test run ended with a stalling node, bug report: ethereum/go-ethereum#3466

@luclu
Copy link
Contributor

luclu commented Dec 19, 2016

I removed the --cache 1024 flag which should be unnecessary for LES.

@luclu
Copy link
Contributor

luclu commented Dec 19, 2016

@frozeman I'm getting quite a lot of:

[2016-12-19 16:22:03.251] [ERROR] ipcProviderBackend - Send request failed { code: -32000, message: 'No trusted canonical hash trie' }

@frozeman
Copy link
Contributor

Is cpp using ropstein, instead of ropsten?

Parity uses: parity --chain ropsten, which we might want to support at some point

@alexvandesande
Copy link
Collaborator Author

I will separate the on boarding and splash screen fixes in their own PRs

@alexvandesande
Copy link
Collaborator Author

Please review for functionality, but we will only merge when we feel the light client works as expected

@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants