Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844 Implementers' Call #5 #670

Closed
timbeiko opened this issue Nov 19, 2022 · 7 comments
Closed

EIP-4844 Implementers' Call #5 #670

timbeiko opened this issue Nov 19, 2022 · 7 comments

Comments

@timbeiko
Copy link
Collaborator

timbeiko commented Nov 19, 2022

Meeting Info

馃搯 Subscribe to the Ethereum Protocol Call calendar for calendar invites

Agenda

@gakonst
Copy link

gakonst commented Nov 21, 2022

Code here https://github.com/gakonst/stress4844, tested for 128KB, blocked on finding an MEV Boost builder for 512KB/1024KB etc.

I've been spamming https://goerli.etherscan.io/address/0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa from https://goerli.etherscan.io/address/0xf5f02208279382cb8e6af943dafa8eac418bbdd3.

@asn-d6
Copy link

asn-d6 commented Nov 21, 2022

It might be fruitful to spend a few moments discussing whether we want to make sidecars optional when a block has no blob transactions. We have a cryptography PR which fixes an issue presented when this happens: ethereum/consensus-specs#3093

However, if other subsystems would benefit from sidecars being optional, we might be able to set stricter invariants in the cryptography library as well.

@adietrichs
Copy link
Member

One more (hopefully last) spec PR update:

@protolambda
Copy link

After 5930 I think we can update the EIP to "review" status. Any objections?

@holgerd77
Copy link

holgerd77 commented Nov 22, 2022

Code here https://github.com/gakonst/stress4844, tested for 128KB, blocked on finding an MEV Boost builder for 512KB/1024KB etc.

I've been spamming https://goerli.etherscan.io/address/0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa from https://goerli.etherscan.io/address/0xf5f02208279382cb8e6af943dafa8eac418bbdd3.

That is super interesting, could you expand on this a bit what this stress test actually does? Does it simulate a (modified) devp2p network? Locally? Distributed? Or does it somehow interact with an existing network simulating an increased load with some tricks?

Anyhow: pretty cool! 馃檪 馃挴

@adietrichs
Copy link
Member

For completeness: Just merged a tiny additional PR to clarify that the return data follows usual EVM big endianness:

@timbeiko
Copy link
Collaborator Author

Closed in favour of #679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants