Greeter in LLL (untested!) #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no simple way to extract ABI from LLL sources. In fact, LLL does not burden itself with such extravagance as human-readable function names. Therefore, this file has been extracted from my `lll` branch as-is.
|
|
pipermerriam
approved these changes
Dec 5, 2017
There was a problem hiding this comment.
Contract looks fine. I'm good merging this into the codebase for now. I'd be interested in adding support to $ populus init for something like a --lll or --serpent flag which determined the initial compiler settings and which type of greeter contract was seeded.
veox
added a commit
to veox/populus
that referenced
this pull request
Dec 8, 2017
Will allow easier `populus init --lll`, which was proposed in PR ethereum#397.
veox
added a commit
to veox/populus
that referenced
this pull request
Dec 11, 2017
Will allow easier `populus init --lll`, which was proposed in PR ethereum#397.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Nothing; everything is fine.
What's this about then?..
I'd like to develop a project in LLL. I like Populus. Having a greeter contract seems like a logical first step. So - here's one.
As to the rest: there's no simple way to generate "web3-friendly" ABI from LLL sources (yet), which seems to be required to feed the compiler backend.
Therefore, this file has been extracted from my
lllbranch as-is.Cute Animal Picture
Brown surgeonfish, a low-trophic-level aquatic animal. (Image source article.)