Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIGHASH opcode #226

Closed
jannikluhn opened this issue Dec 18, 2017 · 1 comment
Closed

Add SIGHASH opcode #226

jannikluhn opened this issue Dec 18, 2017 · 1 comment
Assignees
@jannikluhn
Labels
eth2.0
Projects
Sharding Phase 1 - Stage 1

Comments

@jannikluhn
Copy link
Contributor

jannikluhn commented Dec 18, 2017 •
edited
Loading

What is wrong?

Checking transaction signatures in account abstraction (#225) involves calculating the hash of the transaction, excluding the data field containing the signature itself. This is not possible right now, as there are no opcodes for all transaction fields.

How can it be fixed

Add an opcode SIGHASH with byte value 0x3f that gets sha3(rlp(tx \ {data})), where tx \ {data} refers to the transaction without the data field.
@hwwhww hwwhww added this to In progress in Sharding Phase 1 - Stage 1 Jan 8, 2018
@hwwhww hwwhww moved this from In progress to To Do in Sharding Phase 1 - Stage 1 Jan 8, 2018
@jannikluhn jannikluhn self-assigned this Jan 8, 2018
@jannikluhn
Copy link
Contributor Author

Will include this in #230 because it's needed for testing there.

@jannikluhn jannikluhn mentioned this issue Jan 10, 2018
Merged
@hwwhww hwwhww mentioned this issue Jan 12, 2018
Closed
@jannikluhn jannikluhn mentioned this issue Jan 12, 2018
Closed
@jannikluhn jannikluhn moved this from To Do to Done in Sharding Phase 1 - Stage 1 Jan 16, 2018
@Magicking Magicking mentioned this issue Jan 27, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannikluhn jannikluhn

Labels
eth2.0
Projects
No open projects
Sharding Phase 1 - Stage 1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jannikluhn