SIGHASH opcode #259
Merged
SIGHASH opcode #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Jan 11, 2018
| @@ -189,3 +189,7 @@ def returndatacopy(computation): | |||
| value = computation.return_data[returndata_start_position: returndata_start_position + size] | |||
|
|
|||
| computation.memory.write(mem_start_position, size, value) | |||
|
|
|||
|
|
|||
| def sighash(computation): | |||
There was a problem hiding this comment.
Is there an EIP for this? If so, could we link it in the docstring.
There was a problem hiding this comment.
There isn't, unfortunately.
| gas=gas, | ||
| gas_price=self.msg.gas_price, | ||
| origin=self.msg.origin, | ||
| sig_hash=self.msg.sig_hash, |
There was a problem hiding this comment.
This has a "bad smell".
The sighash falls into the same category as the block data which indicates there should be a single location this value is stored. Yet it is copied for each level of computation.
After some investigation, the same is true for msg.gas_price and msg.origin. This isn't something we need to fix now, but I think it's worth investigating how we can remove this duplication.
Issue opened here: #262
There was a problem hiding this comment.
I agree. I must admit that I simply copied the msg.origin behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the SIGHASH opcode that puts the hash of the transaction excluding the data field on the stack.
Closes #226