Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: Some improvements to PeerPoolSubscriber #1056

Merged
merged 1 commit into from
Jul 21, 2018
Merged

p2p: Some improvements to PeerPoolSubscriber #1056

merged 1 commit into from
Jul 21, 2018

Commits on Jul 20, 2018

  1. p2p: Some improvements to PeerPoolSubscriber 

    * Renamed to PeerSubscriber because that's what it really is
* New @AbstractMethod max_queue_size, to force each subscriber to define their own
* Peer now keeps a list of actual PeerSubscribers instead of just their msg queues
* PeerSubscriber provides APIs to add msgs to queue and check queue
  size, abstracting underlying implementation
* If an attempt is made to add a msg but the queue is full, we log a
  warning and drop the msg (Closes: ethereum#1032)
    @gsalgado
    gsalgado committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    e3bc0d2 View commit details
    Browse the repository at this point in the history