Prefix trinity version with eth if trinity not installed #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
approved these changes
Jul 23, 2018
| @@ -5,7 +5,9 @@ | |||
| try: | |||
| __version__ = pkg_resources.get_distribution("trinity").version | |||
| except pkg_resources.DistributionNotFound: | |||
| __version__ = pkg_resources.get_distribution("py-evm").version | |||
| __version__ = "eth-{0}".format( | |||
There was a problem hiding this comment.
Since this is inside the trinity module, should we just let it crash?
If the concern is confusion from user-reported versions, I still think we might run into problems. If the display on their screen is eth-v1.2.3 and we ask them the version, it seems totally plausible that they just say "v1.2.3".
There was a problem hiding this comment.
Merging as-is and punting on a better change which pulls the local git commit and/or reads the version string from setup_trinity.py
pipermerriam
deleted the
piper/prefix-trinity-version-with-eth-if-trinity-not-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When
trinityis not installed we fall back to thepy-evmversion for the version number. We don't want to have any confusion when viewing this numberHow was it fixed?
When this happens, prefix the version string with
eth-Cute Animal Picture