Use shared ProcessPoolExecutor across all services #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
force-pushed
the
piper/service-context-api
branch
from
9097cf1
to
d4bc403
Compare
pipermerriam
changed the title
carver
approved these changes
Aug 8, 2018
| @settings(max_examples=10) | ||
| @settings( | ||
| max_examples=10, | ||
| deadline=4000, |
There was a problem hiding this comment.
Interesting, was this taking a really long time with just a few examples?
There was a problem hiding this comment.
I think it's because it runs 10 examples, each which populate a trie with 1000 nodes, which as we know is a computationally expensive operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revamp of #1155
What was wrong?
fixes #1076
In the chain and state syncers there is an API for running computationally heavy workloads in a process pool of workers. The worker pool is automatically sized according to the number of cpus available on the machine. This pattern is quite useful, however, if used concurrently by two services, it would result in multiple pools being created, and would likely overwhelm the CPU load on the machine.
How was it fixed?
The
_run_in_executorAPI is now available for allBaseServicesubclasses. This implements a quick-and-easy solution using a global executor pool which will be re-used across allBaseServicesubclasses within a single process.This PR also contains additional cleanup:
BasePeerclass is now instantiated with the cancel token from thePeerPool.BaseService.loopin the various asyncio APIs.Cute Animal Picture