Implement BaseService.run_task(awaitable) #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsalgado
force-pushed
the
issue-1118
branch
2 times, most recently
from
65b1f59
to
c0d19de
Compare
pipermerriam
requested changes
Aug 13, 2018
| await awaitable | ||
| except OperationCancelled: | ||
| pass | ||
| self._tasks.add(asyncio.ensure_future(f())) |
There was a problem hiding this comment.
I'm not seeing anywhere that we cleanup finished tasks. Things like Discovery.mayber_connect_to_more_peers which run periodically will result in an ever growing memory footprint. It looks like we need something to do periodic garbage collection for tasks that are complete.
There was a problem hiding this comment.
That's why I used a WeakSet for self._tasks; once a task is done there should be no strong reference to it left, and then it is discarded from the set.
There was a problem hiding this comment.
It runs the given awaitable in the background, catches/ignores OperationCancelled and ensures the task is finished before the service is finished. Also removes trinity.Node.add_service() as the same functionality is provided by BaseService.run_child_service() Closes: ethereum#1118
It's no longer needed as of the previous commit
pipermerriam
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It runs the given awaitable in the background, catches/ignores
OperationCancelled and ensures the task is finished before the
service is finished.
Also removes trinity.Node.add_service() as the same
functionality is provided by BaseService.run_child_service()
Closes: #1118