Use trinity.Server in LightNode #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids duplicating some logic to run a PeerPool/DiscoveryService, but also causes LightNode to setup NAT port forwarding and accept incoming peer connections. Also changed the default peer limit when running in light mode to half of the limit used when in full mode. Closes: ethereum#1003
pipermerriam
approved these changes
Aug 14, 2018
What's the intuition behind this change? |
|
@carver a lower default limit seemed to make sense for light mode as that generally means low-end hardware. if we don't accept incoming connections that probably doesn't matter as with discv4 we'd probably never find more than a handful peers, but now that we accept incoming connections we're more likely to reach the limit |
voith
pushed a commit
to voith/py-evm
that referenced
this pull request
Aug 16, 2018
This avoids duplicating some logic to run a PeerPool/DiscoveryService, but also causes LightNode to setup NAT port forwarding and accept incoming peer connections. Also changed the default peer limit when running in light mode to half of the limit used when in full mode. Closes: ethereum#1003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplicating some logic to run a PeerPool/DiscoveryService,
but also causes LightNode to setup NAT port forwarding and accept
incoming peer connections.
Also changed the default peer limit when running in light mode to half
of the limit used when in full mode.
Closes: #1003