Properly test the auth/p2p handshake on incoming peer connections #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Aug 16, 2018
carver
reviewed
Aug 21, 2018
| await initiator_peer.do_p2p_handshake() | ||
| await initiator_peer.do_sub_proto_handshake() | ||
|
|
||
| assert len(server.peer_pool.connected_nodes) == 1 |
There was a problem hiding this comment.
FYI, this seemed to have a race condition that I resolved with https://github.com/ethereum/py-evm/pull/1184/files#diff-eea39f2a22cc7d4655fd68c9d521c780R135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #656