Re-organize the fixture filler helper tools #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
approved these changes
Aug 28, 2018
| @@ -34,10 +38,12 @@ | |||
| from eth.rlp.headers import ( | |||
| BlockHeader, | |||
| ) | |||
| from eth.tools.fixture_tests import ( | |||
| from eth.tools._utils.hashing import ( | |||
There was a problem hiding this comment.
Ooh, I like this as an indication that the utils are meant to be for internal use.
There was a problem hiding this comment.
Yeah, I want to push that pattern everywhere now that I've seen it in code.
There was a problem hiding this comment.
cc @njgheorghita @cburgdorf @davesque @dylanjw for something that is fair game to push out across any/all of our repositories.
There was a problem hiding this comment.
I also added it to the default .gitignore for generated docs in the template: https://github.com/carver/ethereum-python-project-template/blob/master/.gitignore#L48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As part of #1209 I ended up re-using some of the things from the fixture builder tests, and ended up doing a reasonably big re-organization of that code.
How was it fixed?
Re-organized the code from the old
test_builder. This is mostly to get a bunch of unrelated changes out of #1209 before I wrap it up.Cute Animal Picture