add handling for MalformedMessage during peer connection #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsalgado
approved these changes
Sep 3, 2018
p2p/peer.py
Outdated
| except MalformedMessage: | ||
| # This is kept separate from the `expected_exceptions` to be sure that we aren't | ||
| # silencing an error in our authentication code. | ||
| self.logger.info('Got malformed response from %r', remote) |
There was a problem hiding this comment.
I think we should use self.logger.exception() instead as this should not happen and by doing that we'd at least have the data and the original error in the logs. Also, the comment is not accurate as this would not silence a bug in the authentication code -- it could silence a bug in our decoding of messages
There was a problem hiding this comment.
Went with the strategy of using ERROR for this message but dumping full stacktrace in DEBUG logs.
pipermerriam
force-pushed
the
piper/handle-deserialization-error
branch
from
21c68e0
to
5f6557d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1241
What was wrong?
Unhandled exception when connecting to peers.
How was it fixed?
Added an
exceptclause to handle it.Cute Animal Picture