Clearer service exceptions #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if child service can't start - ValidationError mildly more helpful than RuntimeError Also, prefer run_child_service over run_task, because it has more info to give better error messages.
pipermerriam
requested changes
Sep 3, 2018
| @@ -732,7 +732,7 @@ def unsubscribe(self, subscriber: PeerSubscriber) -> None: | |||
| peer.remove_subscriber(subscriber) | |||
|
|
|||
| async def start_peer(self, peer: BasePeer) -> None: | |||
| self.run_task(peer.run()) | |||
| self.run_child_service(peer) | |||
There was a problem hiding this comment.
This seems problematic as I don't see a mechanism for peers which stop to be removed from the self._child_services set, which will result in that set growing in an unbounded nature. I know that the task set uses a WeakSet to ensure that old tasks are garbage collected (which I'm realizing we should maybe validate that at some point?).
carver
force-pushed
the
service-exceptions
branch
from
987dcb0
to
0961371
Compare
|
Weird, my |
carver
force-pushed
the
service-exceptions
branch
from
0961371
to
232980a
Compare
|
You probably missed #1229 |
Ah yes, thanks @cburgdorf . I'm actually using |
|
Wait, it's worse/weirder than that, the tox envlist didn't get changed either. |
|
Oops 🙈🙉 |
pipermerriam
approved these changes
Sep 3, 2018
|
👍 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When child services couldn't start (in
run_child_serviceorrun_daemon), the stack had lost who the calling parent was because of asyncio indirection.How was it fixed?
Also, prefer
run_child_serviceoverrun_taskin peer, because it has more infoto give better error messages.
Cute Animal Picture