Fix bug in CREATE2 address generation + add test #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/fix/create2
branch
3 times, most recently
from
fdd5b3a
to
09bcbd8
Compare
cburgdorf
changed the title
pipermerriam
approved these changes
Oct 9, 2018
| decode_hex(code) | ||
| ) | ||
|
|
||
| assert to_checksum_address(encode_hex(address)) == expected |
There was a problem hiding this comment.
This is generally fine, but our idiomatic way to compare addresses is to use eth_utils.is_same_address which handles comparison of differently formatted addresses.
There was a problem hiding this comment.
Ah, now that you mentions it, I remember you mentioned it before 😅 Fixed it.
cburgdorf
force-pushed
the
christoph/fix/create2
branch
from
09bcbd8
to
bda206d
Compare
cburgdorf
force-pushed
the
christoph/fix/create2
branch
from
bda206d
to
292d111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The generated address for the new CREATE2 opcode turned out to be wrong. By the time that I implemented it, there were no test cases so the implementation was a shot in the dark (and still kinda is, as this only partly covers what CREATE2 does).
Now we do have test cases and they discovered a bug in our implementation.
How was it fixed?
Correctly interpret salt + add tests.
Cute Animal Picture