Fix mainnet genesis configuration #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
force-pushed
the
piper/fix-mainnet-genesis-configuration
branch
from
85fd8eb
to
5c17e70
Compare
pipermerriam
commented
Oct 25, 2018
| (b'\xff' * 320, None, ADDRESS_2, True, 54888), | ||
| (b'\xff' * 32, None, ADDRESS_2, True, 35333), | ||
| (b'\xff' * 32, None, ADDRESS_2, False, 35345), | ||
| (b'\xff' * 320, None, ADDRESS_2, True, 54840), |
There was a problem hiding this comment.
These gas numbers changed because the genesis difficulty they are operating against changed which changes the gas limit for the pending_header that the estimation is done against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The parameters for our mainnet genesis were incorrect.
How was it fixed?
Updated to use correct genesis parameters.
Cute Animal Picture