Ensure Trinity handles SIGTERM send to main process #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when sending a SIGTERM to the Trinity main process, Trinity doesn't shut down gracefully. The main process shuts down but the child processes doesn't. This change does two things: - print out the main process id at boot - handle SIGTERM correctly Relates to #1461
pipermerriam
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently, when sending a SIGTERM to the Trinity
main process, Trinity doesn't shut down gracefully.
The main process shuts down but the child processes
doesn't.
This can easily be reproduced:
Run
trinityTake note of the
pidprinted as Started main process (pid=<pid-to-note>)Open another terminal and run `kill
Notice that the main process is killed but the child processes keep on running.
How was it fixed?
This change does two things:
Relates to #1461
Cute Animal Picture