Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync ethereum/eth2.0-specs#374 part1: types, constants, deposit_helpers #1700

Merged
merged 10 commits into from
Jan 10, 2019
Merged

Sync ethereum/eth2.0-specs#374 part1: types, constants, deposit_helpers #1700

merged 10 commits into from
Jan 10, 2019

Commits on Jan 10, 2019

  1. Sync ethereum/consensus-specs#374 part1: types, constants, deposit_he… 

    …lpers
    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    64925be View commit details
    Browse the repository at this point in the history

  2. Move some changes to next PR

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    07df477 View commit details
    Browse the repository at this point in the history

  3. Bugix: denoms.gwei != GWEI_PER_ETH 

    Define `GWEI_PER_ETH` in `eth/beacon/constants.py` and replace `denoms.gwei` with it.
    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    ae65c40 View commit details
    Browse the repository at this point in the history

  4. Apply PR#1677 feedback

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    5c140b1 View commit details
    Browse the repository at this point in the history

  5. Refactor

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    5850e0b View commit details
    Browse the repository at this point in the history

  6. Refactor and add testcases of test_get_shuffling_is_complete

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    30e6cea View commit details
    Browse the repository at this point in the history

  7. PR feedback

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    6fb899b View commit details
    Browse the repository at this point in the history

  8. PR feedback 

    1. Move `FAR_FUTURE_SLOT` to `eth.beacon.constants`
2. Rename `get_pending_validator` to `create_pending_validator`
3. Add some docstrings
    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    7412023 View commit details
    Browse the repository at this point in the history

  9. Remove eth/beacon/exceptions.py

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    41a9439 View commit details
    Browse the repository at this point in the history

  10. PR feedback

    @hwwhww
    hwwhww committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    d2f76bd View commit details
    Browse the repository at this point in the history