Use some general state tests as transaction tests; Ensure txn type_id
#2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Mar 15, 2024
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Mar 15, 2024
fselmo
force-pushed
the
transaction-tests-and-fix-type-id-txn-issue
branch
from
909c949
to
019c18a
Compare
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Mar 16, 2024
fselmo
force-pushed
the
transaction-tests-and-fix-type-id-txn-issue
branch
from
019c18a
to
296fc8e
Compare
fselmo
force-pushed
the
transaction-tests-and-fix-type-id-txn-issue
branch
from
296fc8e
to
8e25af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
SpoofTransactionis usually used to turn an unsigned transaction into a "signed" transaction for estimating gas for example. eth-tester usesSpoofTransactionfor these purposes and we need to make sure that it also accounts for atype_idwhich is a part of theSignedTransactionAPI.How was it fixed?
type_idvalues toSpoofTransactionsince it should use all attributes from theSignedTransactionAPI.Todo:
Cute Animal Picture
prompt:
iterate on 'snakes transitioning from the Shanghai city life to a life in Cancun with a sign that says "Cancun"' but make 'transactions' a theme