Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude scripts from wheels #2170

Merged
merged 2 commits into from Apr 16, 2024
Merged

Exclude scripts from wheels #2170

merged 2 commits into from Apr 16, 2024

Conversation

reedsa
Copy link
Collaborator

@reedsa reedsa commented Apr 16, 2024 •
edited

What was wrong?

Error importing when using pytest due to scripts being included as a package.

How was it fixed?

Exclude scripts when building the wheel (setup.py)
Include scripts for the distribution (MANIFEST.in)

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Screen Shot 2024-04-16 at 11 04 05 AM

@fselmo fselmo marked this pull request as ready for review April 16, 2024 17:12
fselmo
fselmo approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good to me 👍🏼

@reedsa reedsa merged commit 24bf1e4 into ethereum:main Apr 16, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob Awaiting requested review from pacrob

@kclowes kclowes Awaiting requested review from kclowes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reedsa @fselmo