Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 support #2171

Merged
merged 4 commits into from Apr 18, 2024
Merged

Add python 3.12 support #2171

merged 4 commits into from Apr 18, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 17, 2024

What was wrong?

closes #2169

How was it fixed?

  • Add relevant Python 3.12 CI runs, copy the new windows CI setup from the template.
  • Bump hypothesis to >6,<7 (this is only for tests install extra, should be OK / non-breaking)
  • Silence some minor warnings related to new hypothesis version. When @given() is used with a function-scoped fixture, it doesn't re-generate the values at the function level. I think this is OK for the tests that had this issue but double check to make sure I didn't miss anything.
  • Use an int (10**18) instead of a float (10e18) for random.randint() as it now raises an exception.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Screenshot 2024-04-17 at 14 41 42

@fselmo fselmo force-pushed the add-python-312-support branch 2 times, most recently from ae7304d to d8b90c6 Compare April 17, 2024 20:18
@fselmo fselmo marked this pull request as ready for review April 17, 2024 20:41
@fselmo fselmo requested a review from kclowes April 17, 2024 20:42
@fselmo fselmo requested a review from reedsa April 17, 2024 20:42
@fselmo fselmo changed the title Add python 312 support Add python 3.12 support Apr 17, 2024
Copy link
Collaborator

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@fselmo fselmo merged commit 53b9e87 into ethereum:main Apr 18, 2024
54 checks passed
@fselmo fselmo deleted the add-python-312-support branch April 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Officially support Python 3.12
4 participants