Shard chain #570
Merged
Shard chain #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
approved these changes
Apr 19, 2018
|
|
||
| def _check_shard_id(self, header_or_collation: Union[CollationHeader, Collation]) -> None: | ||
| if header_or_collation.shard_id != self.shard_id: | ||
| raise ValueError("Header or collation belongs to shard {} instead of shard {}".format( |
There was a problem hiding this comment.
ValidationError would be more inline with other library conventions. Also, this could be done as a stand-alone validator function to reduce class size.
| try: | ||
| self.get_header_by_hash(header.hash) | ||
| except CollationHeaderNotFound: | ||
| raise ValueError("Cannot set unknown header as canonical: {}".format( |
There was a problem hiding this comment.
Maybe re-raise CollactionHeaderNotFound with this message instead of using ValueError?
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Shard chain class was missing.
How was it fixed?
A basic shard chain class has been added, along with some minor changes in the shard db.
Right now it's a very thin wrapper around the shard db. Originally I had implemented some additional functionality, but I was unsure what we'll actually end up using so I removed all but the most basic stuff. I think extending it on the go as needed is the better approach.
Cute Animal Picture