start typing

[pacrob]

This is the initial experimental typing effort. Pay no attention to this PR, just here for reference. It will be closed, not merged.

What was wrong?

py-geth has no types!

Related to Issue #116

How was it fixed?

Added mypy and typed files.

Converted to using pydantic models for GethKwargs and GenesisData.

Todo:

• Clean up commit history

• clean TODOs

• clean breakpoints

• Add or update documentation related to these changes

• Add entry to the release notes

Cute Animal Picture

[DavidRomanovizc]

And here too. I think it might look something like this:

@property
def ipc_path(self) -> str:
    return getattr(self.geth_kwargs, "ipc_path", os.path.abspath(
        os.path.expanduser(
            os.path.join(
                self.geth_kwargs.data_dir,
                "geth.ipc",
            )
        )
    ))

[DavidRomanovizc]

write_genesis_file currently contains separate parameters clique_period and clique_epoch. But, the circleci output shows that the function receives a clique from GenesisData, I can suppose, that containing both period and epoch. And I think, we should update signature to accepting a single clique parameter

Like this:

def write_genesis_file(
    ...
    clique: Optional[Dict[str, int]] = None,
):
    ...
    if clique is None:
        clique = {"period": 5, "epoch": 30000}
    if config is None:
        config = {
            ...
            "clique": {"period": clique.get("period"), "epoch": clique.get("epoch")},
        }
    ...