Pull in most template updates #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can get big with installed libraries. On a relatively small release of eth-portal, this one change cut the .tar.gz release size from 574Kb to 14Kb.
Don't push .tox file to tar.gz release
* Tweaks to release process * Drop python 3.6
toxinidir won't mean anything in a Makefile
Upgrade isort
- Clean up github PR template to remove double links to the newsfragment README.md - Clean up some typos and make some minor refactors.
- It is not recommended to invoke ``setup.py`` directly, instead opting for ``python -m build`` for the commands in this commit (see: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html) - Add newsfragment for ethereum#70
Do not invoke `setup.py` directly; minor refactor + cleanup
bump docs dependencies, add readthedocs requirements
* new issue and pr templates
* convert bash scripts to py
* bump versions in dependencies and ci builds * move tox to [dev] per issue ethereum#34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps
* remove gitter, testing setup, and pandoc sections, add quotes to dev install
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
* template cleanup following initial merge with py-evm * add flake8 pin comment * correct license years * add pin note to mypy
…m#81) * apply template updates found following merge with eth-typing * add build as a dev dependency * remove timeout from pytest.ini, it doesn't do anything without pytest-timeout as a dep
pacrob
force-pushed
the
upgrade-template
branch
from
026dabd
to
ff4c14b
Compare
pacrob
changed the title
pacrob
force-pushed
the
upgrade-template
branch
3 times, most recently
from
4e8955b
to
fac7b91
Compare
pacrob
force-pushed
the
upgrade-template
branch
2 times, most recently
from
406bda8
to
b23b107
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
b23b107
to
e4f3136
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
40d33e8
to
2fd05d5
Compare
added 2 commits
April 14, 2023 13:18
pacrob
changed the title
pacrob
force-pushed
the
upgrade-template
branch
10 times, most recently
from
26212c6
to
2cd467b
Compare
kclowes
approved these changes
Apr 19, 2023
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
Did this come from the template? I wonder if it works/we should keep it?
Edit: I'm okay removing it for consistency's sake, but it's something that would be nice to add to our repos eventually. Then we don't have to fight with the linter all the time.
newsfragments/validate_files.py
Outdated
| '.removal.rst', | ||
| ".breaking.rst", | ||
| ".bugfix.rst", | ||
| ".deprecation", |
There was a problem hiding this comment.
I think this should be .deprecation.rst?
pyproject.toml
Outdated
There was a problem hiding this comment.
I believe we'll need to add a new [[tool.towncrier.type]] for deprecation as well in order for it to show up on the release notes
setup.py
Outdated
| @@ -67,7 +65,7 @@ | |||
| "pyrsistent>=0.16.0,<0.17", | |||
| ], | |||
| setup_requires=[], | |||
| python_requires=">=3.7, <4", | |||
There was a problem hiding this comment.
nit: I'm not sure that >=3.7.2 should be in the template. I know >=3.7.2 holds for web3.py but I'm not 100% why. I think it's probably better to err wide (as in change this back to 3.7) since pip actually validates this on install 🤷♀️
pacrob
force-pushed
the
upgrade-template
branch
3 times, most recently
from
3a1d41b
to
6ab2589
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
6ab2589
to
b8bc494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The python project template was recently update. This pulls in many of those changes, leaving mypy, flake8, and isort updates for separate prs.
To-Do
Cute Animal Picture