Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash_tree_root cache #68

Merged
merged 2 commits into from May 2, 2019
Merged

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 1, 2019

What was wrong?

Fix #67

How was it fixed?

  1. Add root_cache and remove hash_cache.
  2. Use self.root == other.root in __eq__.

Cute Animal Picture

bird-691816_640

@hwwhww hwwhww requested a review from jannikluhn May 1, 2019 06:04
ssz/sedes/serializable.py Outdated Show resolved Hide resolved
@hwwhww hwwhww merged commit 480e82d into ethereum:master May 2, 2019
@hwwhww hwwhww mentioned this pull request May 2, 2019
pacrob pushed a commit to pacrob/py-ssz that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use hash_tree_root as the basic hash of BaseSerializable
2 participants