New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade template #136
Merged
Merged
Upgrade template #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes problems with releasing when pre-commit changes the file after bumpversion updates it
clean up test_import_and_version
clean up test_import_and_version
Drop the `install pre-commit` step here, as it is installed for all linting ci via the tox env deps
Add `pre-commit install` here since it was removed from ci config
pacrob
force-pushed
the
upgrade-template
branch
3 times, most recently
from
March 25, 2024 18:05
cec86d8
to
223051b
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
March 25, 2024 18:08
223051b
to
49b755d
Compare
reedsa
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Template updates, notably adding python 3.12 support.
Turned off the
yaml
CI job. It hasn't been running since 2019 - #85How was it fixed?
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture