Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return annotated node from HexaryTrie.root_node #103

Closed
3 tasks
carver opened this issue May 13, 2020 · 0 comments · Fixed by #106
Closed
3 tasks

Return annotated node from HexaryTrie.root_node #103

carver opened this issue May 13, 2020 · 0 comments · Fixed by #106

Comments

@carver
Copy link
Contributor

carver commented May 13, 2020

All other traversals return an annotated HexaryTrieNode, but trie.root_node just returns the raw body. The inconsistency seems problematic (and annotations would be nice on the root, too!)

TODOs:

  • actually use self.traverse(()) under the hood for root_node
  • change locations that need the raw root node to either use self.root_node.raw or maybe a custom internal method for speed
  • add a breaking change notice to the CHANGELOG
This was referenced May 13, 2020
Merged
Open
Merged
pacrob added a commit to pacrob/py-trie that referenced this issue Oct 29, 2023
@pacrob
Add pre commit (ethereum#103)
7099bba 
* add pre-commit

* run pre-commit

* skip lint on README.md as it breaks template filling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Annotate HexaryTrie.root_node, and remove setter carver/py-trie
1 participant
@carver