Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated trie.Trie and trie.sync #100

Merged
merged 3 commits into from
May 6, 2020
Merged

Drop deprecated trie.Trie and trie.sync #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f79aaf
Drop deprecated trie.sync module
carver May 6, 2020
a60b249
Remove trie.Trie in favor of trie.HexaryTrie
carver May 6, 2020
3866745
Add release notes for v2 - note breaking changes
carver May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
Unreleased
----------
Unreleased (v2)
---------------

Breaking Changes
~~~~~~~~~~~~~~~~

- Removed trie.Trie -- use trie.HexaryTrie instead
https://github.com/ethereum/py-trie/pull/100
- Removed trie.sync (classes: SyncRequest and HexaryTrieSync)
New syncing helper tools are imminent.
https://github.com/ethereum/py-trie/pull/100

Bugfixes
~~~~~~~~

- Pruning Bugfix: with duplicate values at multiple keys, pruning would sometimes incorrectly
prune out a node that was still required. This is fixed for fresh databases, and unfixable
Expand Down
12 changes: 0 additions & 12 deletions tests/test_deprecated_trie_class.py
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions tests/test_sync.py
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions trie/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import pkg_resources
import warnings

from .binary import ( # noqa: F401
BinaryTrie,
Expand All @@ -9,14 +8,4 @@
)


class Trie(HexaryTrie):
def __init__(self, *args, **kwargs):
warnings.warn(DeprecationWarning(
"The `trie.Trie` class has been renamed to `trie.HexaryTrie`. "
"Please update your code as the `trie.Trie` class will be removed in "
"a subsequent release"
))
super().__init__(*args, **kwargs)


__version__ = pkg_resources.get_distribution("trie").version
209 changes: 0 additions & 209 deletions trie/sync.py
View file
Open in desktop

This file was deleted.