Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: primitives is misspelled in py_ecc.bls module #104

Open
prestwich opened this issue Oct 22, 2020 · 4 comments
Open

Nit: primitives is misspelled in py_ecc.bls module #104

prestwich opened this issue Oct 22, 2020 · 4 comments
Labels
Good First Issue

Comments

@prestwich
Copy link

What is wrong?

Really small nit. primitives is incorrectly spelled primatives in py_ecc.bls.g2_primatives
@hwwhww
Copy link
Contributor

hwwhww commented Oct 23, 2020

Nice catch! 😮

Hmm, although it's a typo, we will have a backward-compatible issue if we just rename the file. Probably need to rename + add an alias primatives for compatibility. 😅

@prestwich
Copy link
Author

I can put out a branch later today👌

@prestwich prestwich reopened this Oct 23, 2020
@prestwich
Copy link
Author

ugh I hit "close with comment" instead of just comment 🤣

@prestwich
Copy link
Author

see #105

pacrob added a commit to pacrob/py_ecc that referenced this issue Oct 29, 2023
@pacrob
drop py37 support (ethereum#104)
8242569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pipermerriam @hwwhww @prestwich