Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose type hints via PEP561 #12

Closed
pipermerriam opened this issue Oct 17, 2018 · 0 comments
Closed

Expose type hints via PEP561 #12

pipermerriam opened this issue Oct 17, 2018 · 0 comments
Labels
Good First Issue

Comments

@pipermerriam
Copy link
Member

blocked until #11 is complete

What was wrong?

PEP561 allows us to expose type hints from this library to other libraries which use it. Without this, any library which uses py_ecc and mypy style type checking doesn't benefit from the additional type safety.

Definition of done?

Do what was done in ethereum/eth-typing#10 to allow this data to be exposed when this library is installed as a package.
@pipermerriam pipermerriam mentioned this issue Oct 17, 2018
Closed
6ug added a commit to 6ug/py_ecc that referenced this issue Oct 18, 2018
@6ug
[WIP] Enabling type hinting, applied PEP561
5ba076b 
Fixes ethereum#12
@6ug 6ug mentioned this issue Oct 18, 2018
Merged
pacrob pushed a commit to pacrob/py_ecc that referenced this issue Oct 29, 2023
@carver
Merge pull request ethereum#12 from njgheorghita/update-bumpversion
03f00d3 
[WIP] Add changelog instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pipermerriam