Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for behaviors #75

Closed

Conversation

ChihChengLiang
Copy link
Contributor

What was wrong?

Fix #74, add tests to confirm the behavior of the verifying empty public key and signature.

Fix #65 by the way, add tests to confirm the behavior of aggregating empty lists of public key and signature.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver
Copy link
Collaborator

carver commented Jul 8, 2019

I'm on board with having verify() return False for the empty public key, if you'd like to get that folded in now. 👍

@hwwhww
Copy link
Contributor

hwwhww commented May 6, 2020

closing it now since empty aggregate is invalid in the new BLS standard.

@hwwhww hwwhww closed this May 6, 2020
pacrob added a commit to pacrob/py_ecc that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For arbitrary message, is empty signature valid for empty public key? empty sums in BLS
3 participants