Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the x1 point check #121

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fix the x1 point check #121

merged 2 commits into from
Apr 7, 2021

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 7, 2021 •
edited
Loading

What was wrong?

A patch for #117
x1 size check was missing.

Credit to @asanso for finding and reporting it! 🙏

How was it fixed?

Add if x1 >= q check and test case.

Cute Animal Picture

🦑

@hwwhww hwwhww requested a review from CarlBeek April 7, 2021 17:45
CarlBeek
CarlBeek approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we're patching this hole completely now.

@hwwhww hwwhww merged commit 033b4ea into master Apr 7, 2021
@hwwhww hwwhww deleted the fix-z1-check branch April 7, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlBeek CarlBeek CarlBeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @CarlBeek