Support dynamic encodings #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup is slow, so skipping it in normal pytest ways is ineffective. Now it's easier to run something like `pytest tests/core -k mytest` without incurring the slow benchmark setup.
carver
force-pushed
the
test-dynamic-structures
branch
from
b88b361
to
173bdd8
Compare
... and resolve new warnings
carver
force-pushed
the
test-dynamic-structures
branch
from
173bdd8
to
bf46cfd
Compare
|
This PR has a bit of housekeeping. The relevant bits are in the 2nd commit: 97d4771 |
3 tasks
| try: | ||
| return sedes.deserialize(obj) | ||
| except ObjectDeserializationError: | ||
| pass |
There was a problem hiding this comment.
What happens if all of the sedes options result in ObjectDeserializationError. Won't that result in this returning None?
There was a problem hiding this comment.
Yeah, sorry I "marked for review" a bit early. That's one of the TODOs listed above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate how to use dynamic structures in a test, and expose a
DynamicSerializable.I suppose this can fix #112 if it gets merged. It's so small that I'm not sure it's necessary. Then again, I didn't realize it would be such a small addition until I wrote it.
TODO: