Treat bytearray as bytes in Python 3, same as in Python 2 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
pushed a commit
to pacrob/pyrlp
that referenced
this pull request
Sep 21, 2023
Collection of updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the right thing to do. In python2, bytearray is treated as a string. In python3, the code kinda-sorta-explicitly excludes bytearray, but that results in bytearray being treated as a list. Hence, encoding
bytearray('hello')in python 2 decodes to'hello'but doing the same in python 3 decodes to[b'h', b'e', b'l', b'l', b'o'].This PR unifies the behavior, in a direction that I think makes more sense.