Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Buffer.from instead of new Buffer #1525

Merged
merged 1 commit into from Oct 2, 2018
Merged

Use Buffer.from instead of new Buffer #1525

merged 1 commit into from Oct 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2018

What does it do?

This PR replaces all new Buffer with Buffer.from. We should not use Buffer constructor which is deprecated and unsafe.

Any helpful background information?

The behavior of new Buffer() is different depending on the type of the first argument, security and reliability issues can be inadvertently introduced into applications when argument validation or Buffer initialization is not performed.

To make the creation of Buffer instances more reliable and less error-prone, the various forms of the new Buffer() constructor have been deprecated and replaced by separate Buffer.from(), Buffer.alloc(), and Buffer.allocUnsafe() methods.

Check this out: https://nodejs.org/api/buffer.html#buffer_buffer_from_buffer_alloc_and_buffer_allocunsafe

@yann300
Copy link
Collaborator

yann300 commented Sep 19, 2018

thanks for this PR ;) could you rebase please?

@ghost
Copy link
Author

ghost commented Sep 19, 2018

@yann300 Sure, it's ready :)

@yann300 yann300 merged commit 1a7725a into ethereum:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant