compiler tab style fixes. language selector ui behaviour #2108
Conversation
LianaHus
changed the title
yann300
force-pushed
the
master_li
branch
4 times, most recently
from
0cbe0d2
to
0752b06
Compare
| @@ -294,6 +305,16 @@ class CompilerContainer { | |||
| } | |||
| } | |||
|
|
|||
| _updateLanguageSelector () { | |||
| if (this._retriveVersion() < '0.5.7') { | |||
There was a problem hiding this comment.
how this can work? you should probably use semver here.
There was a problem hiding this comment.
:) it works. ok I'll look at it
|
some infos about semver https://www.npmjs.com/package/semver |
| @@ -240,7 +248,9 @@ class CompilerContainer { | |||
|
|
|||
| onchangeLanguage (event) { | |||
| this.compileTabLogic.setLanguage(event.target.value) | |||
| this.compile() | |||
There was a problem hiding this comment.
all the other on* method, just trigger a new compilation. Might be more consistent to to keep the same behavior here
There was a problem hiding this comment.
but there was a issue here. build shouldn't be triggered if there is no autocompile an selected file
There was a problem hiding this comment.
or I can put the check in the compile() function
There was a problem hiding this comment.
but there was a issue here. build shouldn't be triggered if there is no autocompile an selected file
This should done in another PR and all the on* function should be updated.
There was a problem hiding this comment.
ok will create a new PR
will be added in new PR
|
Click on |
fixes https://github.com/ethereum/remix-ide/issues/2100