Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new remix-plugin engine #2166

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Use the new remix-plugin engine #2166

merged 2 commits into from
Jul 9, 2019

Conversation

yann300
Copy link
Collaborator

@yann300 yann300 commented Jul 5, 2019

No description provided.

@yann300 yann300 added the WIP label Jul 5, 2019
@yann300 yann300 force-pushed the newPlugEngine branch 11 times, most recently from b94bd46 to 45e67f7 Compare July 8, 2019 09:00
LianaHus
LianaHus reviewed Jul 8, 2019
View reviewed changes
src/app/components/vertical-icons.js

const EventEmitter = require('events')

const profile = {
name: 'menuicons',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not verticalicons?

@yann300 yann300 removed the WIP label Jul 8, 2019
@LianaHus LianaHus self-requested a review July 8, 2019 17:12
@LianaHus
Copy link
Collaborator

LianaHus commented Jul 8, 2019

+1

@yann300 yann300 merged commit fd9c8d0 into master Jul 9, 2019
@yann300 yann300 deleted the newPlugEngine branch September 29, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mkara 0mkara 0mkara approved these changes

@LianaHus LianaHus Awaiting requested review from LianaHus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yann300 @LianaHus @0mkara