Fix modal dialog callback being called multiple times #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for reproducing:
|
LianaHus
approved these changes
Jul 11, 2019
When the modal closes, we need to remove the DOM element. If not, we create a new EventListener associated with the modal each time the modal shows up. And basically when the user `Cancel` the modal, all the previous callback where the modal was used get called. That's pretty critical
yann300
force-pushed
the
yann300-patch-55
branch
from
2afd3f5
to
9a0f00f
Compare
LianaHus
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the modal closes, we need to remove the DOM element.
If not, we create a new EventListener associated with the modal each time the modal shows up.
And basically when the user
Cancelthe modal, all the previous callback where the modal was used get called.That's pretty critical