getGithubAccessToken API #2273
Merged
getGithubAccessToken API #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
approved these changes
Aug 19, 2019
| @@ -10,14 +10,15 @@ import * as packageJson from '../../../package.json' | |||
| const profile = { | |||
| name: 'settings', | |||
| displayName: 'Settings', | |||
| methods: [], | |||
| methods: ['getGithubAccessToken'], | |||
There was a problem hiding this comment.
that's Personal access tokens in https://github.com/settings/tokens
src/app/tabs/settings-tab.js
Outdated
| @@ -162,4 +163,8 @@ module.exports = class SettingsTab extends ViewPlugin { | |||
| this._deps.themeModule.switchTheme() | |||
| return this._view.el | |||
| } | |||
|
|
|||
| getGithubAccessToken () { | |||
| return new Promise((resolve, reject) => resolve(this.config.get('settings/gist-access-token'))) | |||
There was a problem hiding this comment.
You don't need to return a promise :
return this.config.get('settings/gist-access-token')
yann300
force-pushed
the
getgithubKey_as_api
branch
2 times, most recently
from
75f2549
to
a2e46cf
Compare
yann300
force-pushed
the
getgithubKey_as_api
branch
from
a2e46cf
to
e8b1786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/ethereum/remix-ide/issues/2271