Use registry for getting the access token #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/compiler/compiler-imports.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| 'use strict' | |||
| let globalRegistry = require('../../global/registry') | |||
There was a problem hiding this comment.
You can use const here
src/app/compiler/compiler-imports.js
Outdated
|
|
||
| param += this.githubAccessToken() ? 'access_token=' + this.githubAccessToken() : '' | ||
| // const token = await this.call('settings', 'getGithubAccessToken') | ||
| const token = globalRegistry.get('config').api.get('settings/gist-access-token') // TODO replace with the plugin call above |
There was a problem hiding this comment.
Can you create an issue for that and reference it in the TODO statement ?
| param += this.githubAccessToken() ? 'access_token=' + this.githubAccessToken() : '' | ||
| // const token = await this.call('settings', 'getGithubAccessToken') | ||
| const token = globalRegistry.get('config').api.get('settings/gist-access-token') // TODO replace with the plugin call above | ||
| param += token ? 'access_token=' + token : '' |
There was a problem hiding this comment.
Maybe more readable to do :
const param = token ? `?access_token=${token}` : '?' (or "let param = ..." if you're mutating the param later.
yann300
force-pushed
the
fixListeningOnVyper
branch
from
cfd4acf
to
497b6de
Compare
yann300
force-pushed
the
fixListeningOnVyper
branch
from
497b6de
to
c61de71
Compare
LianaHus
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.