listen on rootFolderChanged #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
yann300-patch-79
branch
from
6fdc9f8
to
aec3b7f
Compare
yann300
force-pushed
the
yann300-patch-79
branch
from
aec3b7f
to
73ccea7
Compare
LianaHus
reviewed
Sep 24, 2019
| @@ -42,6 +42,9 @@ module.exports = class RemixDProvider { | |||
| this.event.trigger('fileExternallyChanged', [path, content]) | |||
| } | |||
| }) | |||
| } else if (data.name === 'rootFolderChanged') { | |||
| // new path has been set, we should reset | |||
| this.event.trigger('folderAdded', [this.type + '/']) | |||
There was a problem hiding this comment.
should we remove the old one?
There was a problem hiding this comment.
i think that 's ok
LianaHus
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That happen when remixd is started and change its target folder: the explorer need to be warned and update accordingly: reload the root folder.
EDIT: this is used when we run remix IDE with electron