ux friendly use of remixd inside electron #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
remixd_electron
branch
from
d0d024c
to
f84f872
Compare
GrandSchtroumpf
approved these changes
Sep 23, 2019
| console.log(error) | ||
| modalDialogCustom.alert( | ||
| 'Cannot connect to the remixd daemon.' + | ||
| 'Please make sure you have the remixd running in the background.' |
There was a problem hiding this comment.
Is it run by default ? Maybe could be good to have a link to documentation.
There was a problem hiding this comment.
yep, there's already a link in the content of the modal
src/app/files/remixd-handle.js
Outdated
| @@ -85,6 +90,10 @@ export class RemixdHandle extends Plugin { | |||
| } | |||
| } | |||
| ) | |||
| } else { | |||
| this.locahostProvider.init((error) => { | |||
There was a problem hiding this comment.
Could be on one line : this.locahostProvider.init(error => connection(error))
| @@ -19,11 +19,14 @@ export class RemixAppManager extends PluginEngine { | |||
| constructor (plugins) { | |||
| super(plugins, settings) | |||
| this.event = new EventEmitter() | |||
| this.donotAutoReload = ['remixd'] // that would be a bad practice to force loading some plugins at page load. | |||
There was a problem hiding this comment.
I'm not sure to understand what it does.
yann300
force-pushed
the
remixd_electron
branch
from
f84f872
to
a4e24d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after #2348