Use Logo in the homepage #2371
Merged
Use Logo in the homepage #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryestew
reviewed
Sep 26, 2019
| let container = yo`<div class="${css.homeContainer} bg-light"> | ||
| <div> | ||
| <div class="alert alert-info clearfix ${css.thisJumboton}"> | ||
| <div class="${css.headlineContainer}"> | ||
| <h2 class="">The new layout has arrived</h2> | ||
| <h2 class="${css.logoContainer}">${img}</h2> |
There was a problem hiding this comment.
It would be better if the img was not in the h2 tag.
yann300
force-pushed
the
logo_homepage
branch
from
902c5a0
to
d2344b6
Compare
ryestew
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fix switching to the file explorer after having imported a file.