fixed editing gists from last session #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
approved these changes
Oct 1, 2019
| @@ -441,35 +441,42 @@ fileExplorer.prototype.toGist = function (id) { | |||
| } | |||
| } | |||
|
|
|||
| async function getOriginalFiles (id) { | |||
There was a problem hiding this comment.
Maybe add a comment with jsdoc synthax so we can understand what this function is doing :
/**
* This function is awesome
* @params id The if of....
*/
async function getOriginalFiles (id) { ... }
src/app/files/file-explorer.js
Outdated
| if (id) { | ||
| const fileList = Object.keys(this.files.origGistFiles) | ||
| const updatedFileList = Object.keys(packaged) | ||
| let originalFileList = getOriginalFiles(id) |
There was a problem hiding this comment.
You're ne reassigning this value later. You can use const
| .filter(fileName => updatedFileList.indexOf(fileName) === -1) | ||
| .reduce((acc, deleteFileName) => ({ | ||
| ...acc, | ||
| [deleteFileName]: null | ||
| }), this.files.origGistFiles) | ||
| }), originalFileList) |
There was a problem hiding this comment.
I've read an article that says that it's actually not a good idea to use spead operator (...) inside a reduce as it's increase the complexity of the function from On to On² (spread operator iterate on each element). Here, the amount of elements is small so it's ok.
You could do that to improve it :
reduce((acc, deleteFileName) => {
delete acc[deleteFileName]
return acc
}, originalFileList)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/ethereum/remix-ide/issues/2382