Make more clearer documentation about unit testing #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR ! |
ryestew
requested changes
Nov 12, 2019
There was a problem hiding this comment.
Thanks for the PR Icegotcha. I'm sorry it took a while to review it. I really appreciate you contribution to the docs. I put a bunch of requests. Some of the requests for changes are to sentences you didn't touch - but your updates showed that a few more edits are needed.
Thanks again
|
@ryestew Sorry for late replying. I followed your reviewing comments and left my own comments about editing. Please check again, Thank you very much. |
|
Hi Icegotcha - thanks so much for the update. I just have 1 last request. Could you squash all of your commits into a single commit? Thanks again |
icegotcha
force-pushed
the
add-more-properly-documentation
branch
from
0838d42
to
8dd5485
Compare
|
@ryestew Done. |
ryestew
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I corrected table writing in markdown.
to
and added more pictures for clearer description, for example: