debugger text improvment #2416
Merged
debugger text improvment #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LianaHus
force-pushed
the
debugger_text
branch
from
41bb1bb
to
b04c534
Compare
GrandSchtroumpf
suggested changes
Oct 29, 2019
| @@ -15,7 +15,7 @@ MemoryPanel.prototype.update = function (calldata) { | |||
| } | |||
|
|
|||
| MemoryPanel.prototype.render = function () { | |||
| return yo`<div id='memorypanel' >${this.basicPanel.render()}</div>` | |||
| return yo`<div id='memorypanel' class='text-monospace small'>${this.basicPanel.render()}</div>` | |||
There was a problem hiding this comment.
Use double quote for attribute value class="text-monospace small"
| <div class="${css.stepDetail} column">${this.stepDetail.render()}</div> | ||
| </div> | ||
| </div>` | ||
| var headView = yo` |
| </div> | ||
| </div>` | ||
| var headView = yo` | ||
| <div id='vmheadView' class="${css.vmheadView} container"> |
There was a problem hiding this comment.
use double quote for attribute value id="..."
| ${this.fullStoragesChangesPanel.render()} | ||
| </div> | ||
| </div>` | ||
| var view = yo` |
There was a problem hiding this comment.
Same as above const & doubleQuotes
| @@ -11,7 +11,7 @@ StackPanel.prototype.update = function (calldata) { | |||
| } | |||
|
|
|||
| StackPanel.prototype.render = function () { | |||
| return yo`<div id='stackpanel' >${this.basicPanel.render()}</div>` | |||
| return yo`<div id='stackpanel' class='text-monospace small' >${this.basicPanel.render()}</div>` | |||
There was a problem hiding this comment.
Double quotes for id and class
| module.exports = { | ||
| formatSelf: formatSelf, | ||
| extractData: extractData | ||
| } | ||
|
|
||
| function formatSelf (key, data) { | ||
| var style = fontColor(data) | ||
| var keyStyle = data.isProperty ? 'color:#847979' : '' | ||
| var keyStyle = data.isProperty ? 'color: var(--info)' : '' |
| if (data.type === 'string') { | ||
| data.self = JSON.stringify(data.self) | ||
| } | ||
| return yo`<label style=${keyStyle}>${key}: <label style=${style}>${data.self}</label><label style='font-style:italic'> ${data.isProperty || !data.type ? '' : ' ' + data.type}</label></label>` | ||
| return yo `<label style='${keyStyle};white-space:pre-wrap;'> ${' ' + key}:<label style=${style}>${' ' + data.self}</label><label style='font-style:italic'> ${data.isProperty || !data.type ? '' : ' ' + data.type}</label></label>` |
There was a problem hiding this comment.
I cannot read this line. Use classes instead of setting the style directly, also format the code.
Also I don't understand why doing : ${' ' + key}, this shoud be ${key}
There was a problem hiding this comment.
this should not be here.
| @@ -55,16 +58,20 @@ function extractData (item, parent, key) { | |||
| } | |||
|
|
|||
| function fontColor (data) { | |||
| var color = '#124B46' | |||
| var color = 'var(--primary)' | |||
| data.type.indexOf('enum') === 0) { | ||
| color = '#0F0CE9' | ||
| color = 'var(--info)' | ||
| } else if ( |
There was a problem hiding this comment.
Create a variable or a function for this if statement that explain what it's. Something like :
function isType(data, types) {
return types.some(type => data.type[0] === type);
}
...
else if (isType(data, ['uint', 'int', 'bool', 'enum'])) { ... }
| @@ -55,16 +58,20 @@ function extractData (item, parent, key) { | |||
| } | |||
|
|
|||
| function fontColor (data) { | |||
There was a problem hiding this comment.
Add comment that describe what is the type. Here is an example from JSDoc:
/**
* Assign the project to an employee.
* @param {Object} employee - The employee who is responsible for the project.
* @param {string} employee.name - The name of the employee.
* @param {string} employee.department - The employee's department.
*/
Project.prototype.assign = function(employee) {
// ...
};
GrandSchtroumpf
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the issue https://github.com/ethereum/remix-ide/issues/2020