Add "allow-popups" to iframe attributes #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a dev-ops question. How often is the plugin updated on remix and remix-alpha? This PR doesn't seem to be applied there yet. |
|
Hi, sorry for the delay, I'll update remix-ide right now. Should be available on remix-alpha in an hour or two. |
|
Awesome thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a plugin which uses external links for the user to open.
Current state for plugins/iframe
The iframe attributes currently include
allow-top-navigation. This allows the user to open a link, but redirects the page, and closes Remix-IDE 👎Changes
This change to add "allow-popups" means the user can click a link without leaving Remix-IDE. 👍
Thanks for making the plugin process easy ⚡ yall rock 🎸 , and I've had a lot of fun 💯