recent workspaces & Start Coding #3654

LianaHus · 2023-04-26T08:32:02Z

netlify · 2023-04-26T08:32:08Z

✅ Deploy Preview for remixproject ready!

Name	Link
🔨 Latest commit	`7f9b0f9`
🔍 Latest deploy log	https://app.netlify.com/sites/remixproject/deploys/65413f7999853c0008396db6
😎 Deploy Preview	https://deploy-preview-3654--remixproject.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ryestew

The helloWorld.sol file should be put into the contracts folder.

Aniket-Engg · 2023-05-03T07:18:18Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

  })

  const [, dispatch] = useReducer(loadingReducer, loadingInitialState)

  const inputValue = useRef(null)

+  useEffect(() => {
+    console.log("useEffHomeFile")


Aniket-Engg · 2023-05-03T07:18:27Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+    console.log("useEffHomeFile")
+    plugin.on('filePanel', 'setWorkspace', async () => {
+      let recents = JSON.parse(localStorage.getItem('recentWorkspaces'))
+      console.log("useEffHomeFilerecents ", recents)


Aniket-Engg · 2023-05-03T07:19:19Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+  const handleSwichToRecentWorkspace = async (e, workspaceName) => {
+    e.preventDefault();
+      await plugin.call('filePanel', 'switchToWorkspace', { name: workspaceName, isLocalhost: false })
+    console.log('The link was clicked.');


Aniket-Engg · 2023-05-03T07:29:47Z

When Remix is loaded first time or in a private window, It should show none or No workspaces for Recent workspaces. For now, it is just blank

When One workspace is created, it shows one recent workspace and other two as undefined

Fix indentation for helloWorld.sol file.

helloWorld.sol should go in contracts folder.
For the content of HelloWorld contract, I propose to add also a method like this:

function print() public pure returns (string memory){
        return "Hello World!";
    }

yann300 · 2023-05-10T07:49:45Z

apps/remix-ide/src/app/files/fileManager.ts

@@ -205,11 +205,11 @@ class FileManager extends Plugin {
      path = this.normalize(path)
      path = this.limitPluginScope(path)
      if (await this.exists(path)) {
-        await this._handleIsFile(path, `Cannot write file ${path}`)
-        return await this.setFileContent(path, data)
+        const newPath = await helper.createNonClashingNameAsync(path, this)


this surely shouln't be here.

you are you in the file manager itself, this isn't a place where you can on the fly update a file name.

well I think it can be the job of FM to manage name conflicts. Who else should do it? It' s a proper service that should be done by default IMHO

yann300 · 2023-05-10T07:52:59Z

apps/remix-ide/src/app/panels/file-panel.js

@@ -154,16 +154,35 @@ module.exports = class Filepanel extends ViewPlugin {
    })
  }

+  saveRecent (workspace) {
+    if (!localStorage.getItem('recentWorkspaces')) {
+      localStorage.setItem('recentWorkspaces', JSON.stringify('"first": "", "second": "", "third": ""'))


why it's not just an array.... ?

i don't know. it feels like manipulation would be easier like that

LianaHus · 2023-05-24T09:10:44Z

The helloWorld.sol file should be put into the contracts folder.

a contract folder does not always exist

yann300 · 2023-06-06T10:29:39Z

apps/remix-ide/src/app/files/fileManager.ts

+      if (await this.exists(path)) {
+        const newPath = await helper.createNonClashingNameAsync(path, this)
+        const content = await this.setFileContent(newPath, data)
+        console.log("newp in write ", newPath)


should be removed

This log should be removed

Aniket-Engg

If a workspace is deleted, it is still shown in recent workspaces

Also, for me, when I open a workspace from recent workspaces, folder icon is open but files inside it are not shown

Aniket-Engg · 2023-06-06T12:23:03Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+    const content = `// SPDX-License-Identifier: MIT
+    pragma solidity >=0.7.0 <0.9.0;
+
+    contract helloWorld {


contract name should start with Capital letter by solidity design

Aniket-Engg · 2023-06-06T12:23:39Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+      await plugin.call('filePanel', 'createWorkspace', wName, 'remixDefault')
+    }
+    await plugin.call('filePanel', 'switchToWorkspace', { name: wName, isLocalHost: false })
+    await plugin.call('filePanel', 'switchToWorkspace', { name: wName, isLocalHost: false }) // don't ask why


Do we really need it?

yes I'm afraid

LianaHus · 2023-06-07T09:44:19Z

If a workspace is deleted, it is still shown in recent workspaces

Also, for me, when I open a workspace from recent workspaces, folder icon is open but files inside it are not shown

good catch. thanks.

after discussing it

LianaHus requested a review from Aniket-Engg April 26, 2023 08:32

LianaHus force-pushed the startCoding branch from cb9e755 to 1698495 Compare April 26, 2023 08:35

LianaHus changed the title ~~recent workspaces WIP~~ recent workspaces Apr 26, 2023

LianaHus changed the title ~~recent workspaces~~ recent workspaces & Start Coding Apr 26, 2023

LianaHus added this to In progress in v0.33.0 - Feature Freeze 26/04 - Release 11/05 via automation Apr 26, 2023

LianaHus moved this from In progress to Review in progress in v0.33.0 - Feature Freeze 26/04 - Release 11/05 Apr 26, 2023

Aniket-Engg force-pushed the startCoding branch 2 times, most recently from fcd7bc8 to 80e6f6c Compare April 28, 2023 08:44

ryestew requested changes May 1, 2023

View reviewed changes

Aniket-Engg force-pushed the startCoding branch 2 times, most recently from ce5e847 to 7eba4ca Compare May 3, 2023 06:50

Aniket-Engg reviewed May 3, 2023

View reviewed changes

Aniket-Engg force-pushed the startCoding branch from 7eba4ca to 9e4d9f2 Compare May 10, 2023 06:50

yann300 reviewed May 10, 2023

View reviewed changes

Aniket-Engg removed this from Review in progress in v0.33.0 - Feature Freeze 26/04 - Release 11/05 May 10, 2023

Aniket-Engg added this to In progress in v0.34.0 - Feature Freeze 12/06 - Release 21/06 via automation May 10, 2023

LianaHus force-pushed the startCoding branch from 9e4d9f2 to 1e9d3de Compare May 25, 2023 11:37

LianaHus added WIP ready-to-review PR ready to review and removed WIP labels May 25, 2023

LianaHus force-pushed the startCoding branch from de84c9c to a0cc039 Compare May 25, 2023 13:04

LianaHus force-pushed the startCoding branch from e1df2ff to 08ffa80 Compare June 5, 2023 08:53

yann300 reviewed Jun 6, 2023

View reviewed changes

Aniket-Engg reviewed Jun 6, 2023

View reviewed changes

yann300 removed this from In progress in v0.34.0 - Feature Freeze 12/06 - Release 21/06 Jun 12, 2023

LianaHus added 8 commits October 20, 2023 17:24

fixing rename workspace

09a6c20

refactoring the saved workspaces to have >3 saved

a8a3112

adding tooltips to home buttons

cd31f6d

reconstructed playground

5ea6f8d

cleanup

ec22432

createing new file every time user clickes on start coding

daa8a06

updated e2e name and cleanup

6a596a1

fixed the filtering of empty warkspaces

24e3100

LianaHus force-pushed the startCoding branch from 97d201a to 24e3100 Compare October 20, 2023 15:24

yann300 added 4 commits October 25, 2023 17:08

fix open default file

1c198c5

e2e wait longer (this use a remote api)

2997134

add file from template

d12cea3

Merge remote-tracking branch 'origin/master' into startCoding

71be1ee

yann300 force-pushed the startCoding branch from 60f91e1 to 71be1ee Compare October 30, 2023 09:24

yann300 requested a review from ryestew October 31, 2023 13:54

Merge remote-tracking branch 'origin/master' into startCoding

41ecde7

yann300 force-pushed the startCoding branch from c1f3a87 to 41ecde7 Compare October 31, 2023 16:41

yann300 added 3 commits October 31, 2023 17:52

linting

7329db7

readd circom activation

3b1be9c

linting

ab101ae

yann300 force-pushed the startCoding branch from d33c79b to ab101ae Compare October 31, 2023 17:45

Merge branch 'master' into startCoding

7f9b0f9

yann300 self-requested a review October 31, 2023 17:55

yann300 approved these changes Oct 31, 2023

View reviewed changes

yann300 enabled auto-merge October 31, 2023 17:56

0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from In progress to Reviewer approved Oct 31, 2023

yann300 merged commit c57e2f6 into master Oct 31, 2023
32 checks passed

0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from Reviewer approved to Done Oct 31, 2023

yann300 deleted the startCoding branch October 31, 2023 19:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

recent workspaces & Start Coding #3654

recent workspaces & Start Coding #3654

LianaHus commented Apr 26, 2023 •

edited

netlify bot commented Apr 26, 2023 •

edited

ryestew left a comment

Aniket-Engg May 3, 2023

Aniket-Engg May 3, 2023

Aniket-Engg May 3, 2023

Aniket-Engg commented May 3, 2023

yann300 May 10, 2023

LianaHus May 24, 2023

yann300 May 24, 2023

LianaHus May 24, 2023

yann300 May 10, 2023

LianaHus May 24, 2023

LianaHus commented May 24, 2023

yann300 Jun 6, 2023

Aniket-Engg Sep 7, 2023

Aniket-Engg left a comment •

edited

Aniket-Engg Jun 6, 2023

Aniket-Engg Jun 6, 2023

LianaHus Aug 29, 2023

LianaHus commented Jun 7, 2023

recent workspaces & Start Coding #3654

recent workspaces & Start Coding #3654

Conversation

LianaHus commented Apr 26, 2023 • edited

netlify bot commented Apr 26, 2023 • edited

✅ Deploy Preview for remixproject ready!

ryestew left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aniket-Engg commented May 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LianaHus commented May 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aniket-Engg left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LianaHus commented Jun 7, 2023

LianaHus commented Apr 26, 2023 •

edited

netlify bot commented Apr 26, 2023 •

edited

Aniket-Engg left a comment •

edited